fix(extension-link): Click handler opens selected link instead of clicked link #3732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in which under certain conditions where multiple links are present, clicking one link will instead open a different link. Specifically, when the editor state shows one link as selected, clicking a different link will open the "selected" link instead.
See also ParabolInc/parabol#7524 where this issue was initially reported for our web app.
Repro
The specific conditions in which editor state does not reflect the clicked link are:
openOnClick
is trueeditable
is falseAs such, I recommend reviewers test with the following patch applied:
With this patch applied, you can reproduce locally with the following steps:
/preview/Marks/Link
After applying the changes in this PR, the Cmd+click on "another one" will open the correct link, https://statamic.com/